8000 [FrameworkBundle] Added resolve-env option to debug:config command by alexandre-daubois · Pull Request #40688 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Added resolve-env option to debug:config command #40688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Added resolve-env option to debug:config command #40688

wants to merge 1 commit into from

Conversation

alexandre-daubois
Copy link
Member

This option replaces environment variables placeholders by their actual value in the command output

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #40582
License MIT
Doc PR see below

I couldn't find any tests nor documentation about this command. If I missed it, I'd be more than pleased to complete this pull request!

@carsonbot carsonbot changed the title [FrameworkBundle] [Console] Added resolve-env option to debug:config command [Console][FrameworkBundle] Added resolve-env option to debug:config command Apr 2, 2021
@alexandre-daubois alexandre-daubois mentioned this pull request Apr 2, 2021
Closed
@alexandre-daubois alexandre-daubois force-pushed the feat-resolve-env-debug-config branch from dddbe3f to f82dbf9 Compare April 2, 2021 19:02
@derrabus derrabus removed the Console label Apr 2, 2021
@carsonbot carsonbot changed the title [Console][FrameworkBundle] Added resolve-env option to debug:config command [FrameworkBundle] Added resolve-env option to debug:config command Apr 2, 2021
@derrabus derrabus added this to the 5.x milestone Apr 2, 2021
jderusse
jderusse reviewed Apr 2, 2021
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the parameter is not just an env variable?

  • %env(resolve:FOO)%
  • %env(A_SECRET)%

@alexandre-daubois alexandre-daubois force-pushed the feat-resolve-env-debug-config branch from f82dbf9 to 7910a87 Compare April 3, 2021 10:08
@alexandre-daubois
Copy link
Member Author
alexandre-daubois commented Apr 3, 2021 •
edited
Loading

What if the parameter is not just an env variable?

  • %env(resolve:FOO)%
  • %env(A_SECRET)%

Thank you for your feedback Jérémy!
You're totally right. The new version should be way better and can now resolve values with different env vars processor. I used Console\Descriptor as an example.

About secret vars, it displays null for now. What could be the expected result about secrets? Opening the vault and displaying them? Not really confortable with this because the command would grow even more, but maybe it's the best way to do?

@alexandre-daubois
[FrameworkBundle] [Console] Added resolve-env option to debug:config …
7d5f1c5 
…command

This option replaces environment variables placeholders by their actual value in the command output
@alexandre-daubois alexandre-daubois force-pushed the feat-resolve-env-debug-config branch from 7910a87 to 7d5f1c5 Compare April 3, 2021 10:19
@fabpot fabpot modified the milestones: 5.4, 6.1 Nov 16, 2021
@fabpot fabpot modified the milestones: 6.1, 6.2 May 20, 2022
@alexandre-daubois
Copy link
Member Author

Transferred to #46821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

Add a way to resolve environment variables in debug:config
5 participants
@alexandre-daubois @jderusse @fabpot @derrabus @carsonbot
0