8000 [Notifier] [FakeSms] Add missing LICENSE and .gitattributes file by OskarStark · Pull Request #40669 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Notifier] [FakeSms] Add missing LICENSE and .gitattributes file #40669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

OskarStark
Copy link
Contributor
Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets
Doc PR

cc @nicolas-grekas

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Apr 1, 2021

Didn't you want to add these files to #40647? I don't understand why this PR?

@OskarStark
Copy link
Contributor Author

Didn't you want to add these files to #40647? I don't understand why this PR?

Sure, I added them in the new PR and spotted they were missing in this bridge too 😄

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Apr 1, 2021
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 993f809 into symfony:5.x Apr 1, 2021
@OskarStark OskarStark deleted the fix/add-missing branch April 1, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0