8000 Update references to the ContainerConfigurator by lerminou · Pull Request #40668 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Update references to the ContainerConfigurator #40668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Update references to the ContainerConfigurator #40668

merged 1 commit into from
Apr 1, 2021

Conversation

lerminou
Copy link
Contributor
@lerminou lerminou commented Apr 1, 2021

follows: e4598c2

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
License MIT

@carson 8000 bot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Apr 1, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.x to 5.2 April 1, 2021 08:56
@nicolas-grekas
Copy link
Member

Thank you @lerminou.

@nicolas-grekas nicolas-grekas merged commit 6608880 into symfony:5.2 Apr 1, 2021
@xabbuh xabbuh mentioned this pull request Apr 1, 2021
Merged
nicolas-grekas added a commit that referenced this pull request Apr 1, 2021
@nicolas-grekas
minor #40670 [FrameworkBundle] fix test (xabbuh)
f9e38df 
This PR was merged into the 5.2 branch.

Discussion
----------

[FrameworkBundle] fix test

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40668
| License       | MIT
| Doc PR        |

Commits
-------

3de5b38 fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lerminou @carsonbot @nicolas-grekas
0