LoginLink create get Request Locale#40641
Merged
fabpot merged 1 commit intosymfony:5.xfrom Apr 2, 2021
roromix:loginlink-get-request-locale
Merged
LoginLink create get Request Locale#40641fabpot merged 1 commit intosymfony:5.xfrom roromix:loginlink-get-request-locale
fabpot merged 1 commit intosymfony:5.xfrom
roromix:loginlink-get-request-locale
Conversation
Member
|
Thanks for the follow-up @roromix. |
Contributor
Author
Nyholm
requested changes
Mar 31, 2021
Member
There was a problem hiding this comment.
Thank you.
You are the best. Writing docs and patching bugs.
I agree with this PR and I do like the changes in LoginLinkHandler. But you need to update the test. I will pass even without any modifications to LoginLinkHandler.
Member
|
If I copy the tests you written (without the changes in |
Contributor
Author
Sorry, i have no idea how to do that. Need help |
Member
|
Here is a patch covering this change: diff --git a/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php b/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php
index 03dd0287d7..12b8f7da4a 100644
--- a/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php
+++ b/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php
@@ -69,7 +69,12 @@ class LoginLinkHandlerTest extends TestCase
if ($request) {
$this->router->expects($this->once())
->method('getContext')
- ->willReturn(new RequestContext());
+ ->willReturn($currentRequestContext = new RequestContext());
+
+ $this->router
+ ->expects($this->exactly(2))
+ ->method('setContext')
+ ->withConsecutive([$this->equalTo((new RequestContext())->fromRequest($request)->setParameter('_locale', $request->getLocale()))], [$currentRequestContext]);
}
$loginLink = $this->createLinker([], array_keys($extraProperties))->createLoginLink($user, $request);
@@ -78,19 +83,15 @@ class LoginLinkHandlerTest extends TestCase
public function provideCreateLoginLinkData()
{
- $request = Request::create('https://example.com');
- $request->setLocale('en');
-
yield [
new TestLoginLinkHandlerUser('weaverryan', 'ryan@symfonycasts.com', 'pwhash'),
['emailProperty' => 'ryan@symfonycasts.com', 'passwordProperty' => 'pwhash'],
- $request,
+ Request::create('https://example.com'),
];
yield [
new TestLoginLinkHandlerUser('weaverryan', 'ryan@symfonycasts.com', 'pwhash'),
['emailProperty' => 'ryan@symfonycasts.com', 'passwordProperty' => 'pwhash'],
- Request::create('https://example.com'),
];
yield [ |
Contributor
Author
|
I still have a lot to learn about the Tests |
fabpot
approved these changes
Apr 2, 2021
Member
|
Thank you @roromix. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 21, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Security] Customize generated Login Link Fix #15147 and add documentation for symfony/symfony#40641 Commits ------- 830b1f3 [Security] Customize generated Login Link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing the documentation for PR#40153 I noticed that the RequestContext :: fromRequest method does not add the '_locale' parameter automaticaly. This new pull request to set _locale parameter to the RequestContext.