8000 Fixes #40633: Progress bar is broken when progress bar character is unicode. by grasmash · Pull Request #40635 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fixes #40633: Progress bar is broken when progress bar character is unicode. #40635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixes #40633: Progress bar is broken when progress bar character is unicode. #40635

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38343f4
Fixes #40633: Progress bar breaks when progress bar character is unic…
grasmash Mar 29, 2021
4d3fa7f
Update ProgressBar.php
grasmash Mar 29, 2021
cc3d8de
Add test.
grasmash Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test.
  • Loading branch information
@grasmash
grasmash committed Mar 31, 2021
commit cc3d8de328a29bc7e21483dfb9c2f513fed0b0b5
15 changes: 15 additions & 0 deletions src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,21 @@ public function testSetFormat()
);
}

public function testUnicode()
{
$bar = new ProgressBar($output = $this->getOutputStream(), 10, 0);
ProgressBar::setFormatDefinition('test', '%current%/%max% [%bar%] %percent:3s%% %message% Fruitcake marzipan toffee. Cupcake gummi bears tart dessert ice cream chupa chups cupcake chocolate bar sesame snaps. Croissant halvah cookie jujubes powder macaroon. Fruitcake bear claw bonbon jelly beans oat cake pie muffin Fruitcake marzipan toffee.');
$bar->setFormat('test');
$bar->setProgressCharacter('💧');
$bar->start();
rewind($output->getStream());
$this->assertStringContainsString(
' 0/10 [💧] 0%',
stream_get_contents($output->getStream())
);
$bar->finish();
}

/**
* @dataProvider provideFormat
*/
Expand Down
0