8000 [Stopwatch] Document new "name" property of StopwatchEvent by simivar · Pull Request #40627 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Stopwatch] Document new "name" property of StopwatchEvent #40627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

[Stopwatch] Document new "name" property of StopwatchEvent #40627

merged 1 commit into from
Mar 29, 2021

Conversation

simivar
Copy link
Contributor
@simivar simivar commented Mar 29, 2021
Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets #37676
License MIT
Doc PR symfony/symfony-docs#...

In Pull Request #37676 a new property was added to the StopwatchEvent which was not documented in CHANGELOG.md file

@derrabus derrabus added this to the 5.2 milestone Mar 29, 2021
chalasr
chalasr requested changes Mar 29, 2021
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target the 5.2 branch also (5.x targetted currently).

@simivar simivar requested a review from chalasr March 29, 2021 15:26
@simivar simivar changed the title [Stopwatch] Document new property in the CHANGELOG [Stopwatch] Document name property of StopwatchEvent Mar 29, 2021
@simivar simivar changed the title [Stopwatch] Document name property of StopwatchEvent [Stopwatch] Document new "name" property of StopwatchEvent Mar 29, 2021
@chalasr chalasr changed the base branch from 5.x to 5.2 March 29, 2021 15:28
@chalasr
Copy link
Member
chalasr commented Mar 29, 2021

Thank you @simivar.

@chalasr chalasr merged commit 54209bb into symfony:5.2 Mar 29, 2021
@simivar simivar deleted the patch-1 branch March 29, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr requested changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Status: Needs Review Stopwatch
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@simivar @chalasr @derrabus @carsonbot
0