8000 [Security] Use more concrete user classes in tests by wouterj · Pull Request #40612 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Use more concrete user classes in tests #40612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2021
Merged

[Security] Use more concrete user classes in tests #40612

merged 1 commit into from
Mar 28, 2021

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Mar 28, 2021 •
edited
Loading
Q A
Branch? 5.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Similar to #40609.

#40145 keeps resisting... this should be the last mocked user & user provider in the 5.2 tests, looking at the failing deps=high build.

@wouterj wouterj requested a review from chalasr as a code owner March 28, 2021 17:10
@carsonbot carsonbot added this to the 5.2 milestone Mar 28, 2021
@wouterj wouterj force-pushed the security-user-changes-tests-2 branch from 6873f7e to 4976b53 Compare March 28, 2021 17:11
@wouterj wouterj force-pushed the security-user-changes-tests-2 branch from 4976b53 to 631408b Compare March 28, 2021 17:23
@chalasr
Copy link
Member
chalasr commented Mar 28, 2021

Thank you Wouter.

@chalasr chalasr merged commit 567e118 into symfony:5.2 Mar 28, 2021
@wouterj wouterj deleted the security-user-changes-tests-2 branch March 28, 2021 17:29
@chalasr
Copy link
Member
chalasr commented Mar 28, 2021

now merged up to 5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @chalasr @carsonbot
0