10000 Add `#[As-prefix]` to service attributes by nicolas-grekas · Pull Request #40556 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add #[As-prefix] to service attributes #40556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

Add #[As-prefix] to service attributes #40556

merged 1 commit into from
Mar 23, 2021

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Mar 23, 2021 •
edited
Loading
Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR renames all attributes that are related to autoconfiguration with the As prefix, as I proposed several times already.

This should help autocompletion, and it's required to not collide with existing class names (eg the Command class, but also the old Controller class, etc.)

I think this As prefix is a convention for the better.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Mar 23, 2021
@nicolas-grekas nicolas-grekas requested a review from chalasr as a code owner March 23, 2021 17:59
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 23, 2021
Merged
@chalasr
Copy link
Member
chalasr commented Mar 23, 2021 •
edited
Loading

Should we rename #[Route]? see discussion in #40555

jderusse
jderusse approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for prefixing these attributes

@nicolas-grekas nicolas-grekas merged commit 45b53fe into symfony:5.x Mar 23, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 23, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the as-attributes branch March 25, 2021 18:17
@jrushlow jrushlow mentioned this pull request Apr 5, 2021
Merged
weaverryan added a commit to symfony/maker-bundle that referenced this pull request Apr 9, 2021
@weaverryan
feature #822 [make:command] lets use attributes if possible (jrushlow)
c1c1386 
This PR was merged into the 1.0-dev branch.

Discussion
----------

[make:command] lets use attributes if possible

Console command attribute class renamed from `ConsoleCommand` => `AsCommand` symfony/symfony#40556

closes #820

Commits
-------

95eafee lets use attributes in commands if possible
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@m-vo m-vo mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@jderusse jderusse jderusse approved these changes

@yceruto yceruto yceruto approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolas-grekas @chalasr @stof @jderusse @yceruto @ogizanagi @carsonbot
0