8000 [FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized by kbond · Pull Request #40544 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized #40544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

[FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized #40544

merged 1 commit into from
Mar 23, 2021

Conversation

kbond
Copy link
Member
@kbond kbond commented Mar 22, 2021 •
edited
Loading
Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Fixes a bug introduced in #40368. When TestBrowserToken in unserialized, $firewallName is null so trying to access it via getFirewallName throws a TypeError.

@carsonbot carsonbot added this to the 5.2 milestone Mar 22, 2021
@nicolas-grekas
Copy link
Member

Thank you @kbond.

@nicolas-grekas nicolas-grekas merged commit 4c2f77e into symfony:5.2 Mar 23, 2021
@fabpot fabpot mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kbond @nicolas-grekas @chalasr @carsonbot
0