WIP: Add PHP 8.1 job to Travis #40532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2bf821 to
39247f8
Compare
|
Apparently, Travis runs PHP 8.0 as |
|
Shouldn't we hold off until the beta's start rolling out at the end of July? Maybe this would allow us to implement this in GH Actions instead of Travis if that is the overall direction we are headed with CI. |
|
@jrushlow I'd like to have a CI job for 8.1 before the beta, in order to monitor Symfony's compatibility. That job would be allowed to fail, of course.
|
39247f8 to
28b030c
Compare
28b030c to
b1f4eb1
Compare
Nyholm
added a commit
that referenced
this pull request
May 15, 2021
… Nyholm) This PR was merged into the 4.4 branch. Discussion ---------- Add a GitHub Action for tests against PHP 8.1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A I'd like to monitor our compatibility with the upcoming PHP 8.1 release. Because I failed miserably at convincing Travis to run our tests with PHP 8.1 (see #40532), I tried to do the same with GitHub Actions. Commits ------- 6a328ae Update .github/workflows/tests.yml 6f1c4b8 PHP 8.1 must not cause the build to fail (yet) b0b4510 Add _run_tests bash function de4f017 Add a GitHub Action for tests against PHP 8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should start testing on PHP 8.1 soon-ish.