8000 [HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cache by xabbuh · Pull Request #40497 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cache #40497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

[HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cache #40497

merged 1 commit into from
Mar 18, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 17, 2021 •
edited
Loading
Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40452
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Mar 17, 2021
@xabbuh xabbuh mentioned this pull request Mar 17, 2021
Closed
@nicolas-grekas
Copy link
Member

I don't think we should do this on 4.4. On 4.4, it should be ppl's job to call the method early enough.

On 5.2, we should call the method when constructing the http_cache service.

@xabbuh xabbuh changed the base branch from 4.4 to 5.2 March 17, 2021 20:18
@xabbuh xabbuh requested a review from OskarStark as a code owner March 17, 2021 20:18
@xabbuh xabbuh changed the title [HttpFoundation] detect changes of $httpMethodParameterOverride after calling getMethod() [FrameworkBundle] enable HTTP method overrides as early as possible with the HTTP cache M 8000 ar 17, 2021
@xabbuh xabbuh modified the milestones: 4.4, 5.2 Mar 17, 2021
@xabbuh
Copy link
Member Author
xabbuh commented Mar 17, 2021

I think you are right. This also fixes the cache key issue.

@carsonbot carsonbot changed the title [FrameworkBundle] enable HTTP method overrides as early as possible with the HTTP cache [HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cache Mar 18, 2021
@chalasr chalasr removed request for dunglas and lyrixx March 18, 2021 14:54
@fabpot
Copy link
Member
fabpot commented Mar 18, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit ab4fcf9 into symfony:5.2 Mar 18, 2021
@xabbuh xabbuh deleted the issue-40452 branch March 18, 2021 16:19
@fabpot fabpot mentioned this pull request Mar 29, 2021
Merged
@aschempp aschempp mentioned this pull request Mar 29, 2021
Closed
This was referenced Mar 29, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @fabpot @chalasr @carsonbot
0