8000 [Mailer] make async-ses required by jderusse · Pull Request #40481 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] make async-ses required #40481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2021
Merged

[Mailer] make async-ses required #40481

merged 1 commit into from
Mar 16, 2021

Conversation

jderusse
Copy link
Member
Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40480
License MIT
Doc PR symfony/symfony-docs#...

AWS S3 signature is not supported anymore, which mean the old "raw HTTP" implementation does not work anymore, and only the implementation that use "async-aws" works.

This PR move "async-aws" to the "requires" section in order to fix that.

@carsonbot carsonbot added this to the 5.2 milestone Mar 16, 2021
@jderusse jderusse changed the title Mailer async-ses required [Mailer] make async-ses required Mar 16, 2021
@carsonbot carsonbot changed the title [Mailer] make async-ses required make async-ses required Mar 16, 2021
@fabpot
Copy link
Member
fabpot commented Mar 16, 2021

Thank you @jderusse.

@carsonbot carsonbot changed the title make async-ses required [Mailer] make async-ses required Mar 16, 2021
@fabpot fabpot merged commit d9a8a05 into symfony:5.2 Mar 16, 2021
@jderusse jderusse deleted the mailer-ses-require branch March 16, 2021 09:48
@fabpot fabpot mentioned this pull request Mar 29, 2021
Merged
@jderusse jderusse mentioned this pull request May 20, 2021
Merged
derrabus added a commit that referenced this pull request May 22, 2021
@derrabus
minor #41307 [Mailer] Remove dead code (jderusse)
5e19343 
This PR was merged into the 5.2 branch.

Discussion
----------

[Mailer] Remove dead code

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Since #40481 the `async-aws/ses` package is required, thus the class always exists. We can remove this check

Commits
-------

52c1934 [mailer] Remove useless code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @fabpot @carsonbot
0