Fix ConstraintViolation#getMessageTemplate() to always return string#40416
Merged
fabpot merged 1 commit intosymfony:5.2from Mar 11, 2021
Conversation
|
Hey! Well done!, Im impressed by this PR. I think @mdlutz24 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus
approved these changes
Mar 10, 2021
fabpot
approved these changes
Mar 10, 2021
cb47a35 to
f6e9132
Compare
Member
|
Can you rebase on the 5.2 branch (I cannot do it for you as I cannot push to your branch). Thank you. |
`ConstraintViolation#getMessageTemplate()`'s inherited signature states that `string` is to be returned by it at all times, yet the implementation returns `null` when no message template had been provided at instantiation. This patch obviates it, returning an empty string when the message template is `null`. Ref: symfony#40415 (comment)
f6e9132 to
72a464e
Compare
xabbuh
approved these changes
Mar 11, 2021
Member
|
Thank you @Ocramius. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConstraintViolation#getMessageTemplate()'s inherited signature states thatstringisto be returned by it at all times, yet the implementation returns
nullwhen no messagetemplate had been provided at instantiation.
This patch obviates it, returning an empty string when the
message template is
null.Ref: #40415 (comment)