8000 [Routing] force stringable object to string in route parameter by garak · Pull Request #40342 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] force stringable object to string in route parameter #40342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[Routing] force stringable object to string in route parameter #40342

wants to merge 9 commits into from

Conversation

garak
Copy link
Contributor
@garak garak commented Mar 2, 2021
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #26992
License MIT
Doc PR none

This is a simple proposal to fix related issue.

@carsonbot carsonbot added this to the 4.4 milestone Mar 2, 2021
derrabus
derrabus reviewed Mar 2, 2021
View reviewed changes
@Nyholm Nyholm added the Routing label Mar 2, 2021
@carsonbot carsonbot changed the title force stringable object to string in route parameter [Routing] force stringable object to string in route parameter Mar 2, 2021
Nyholm
Nyholm reviewed Mar 2, 2021
View reviewed changes
derrabus
derrabus reviewed Mar 2, 2021
View reviewed changes
Nyholm
Nyholm requested changes Mar 2, 2021
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sorry if Fabbot suggested a bunch of CS changes. :/

Nyholm
Nyholm reviewed Mar 2, 2021
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Im happy with this after two small changes.

garak and others added 2 commits March 2, 2021 14:49
@garak
expect expectation when is actually expected
e9e5ac6
@garak @Nyholm
Let'use sprintf instead of strtr
4ff52e2 
Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com>
Nyholm
Nyholm approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Im happy with this.

src/Symfony/Component/Routing/Generator/UrlGenerator.php
Comment on lines +299 to +302
if (!\is_object($param)) {
continue;
}
if (!\is_callable([$param, '__toString'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a future PR can deal with if you pass an array or callable.
Or we may think that is not needed.

@Nyholm
Copy link
Member
Nyholm commented Mar 2, 2021

Oh, Fabbot saw that you missed something when adding the sprintf. :)

@fabpot
Copy link
Member
fabpot commented Mar 4, 2021

I think I agree with @linaori's comments in the related issue, so mostly 👎
In any case, that would be for 5.x.

@fabpot
Copy link
Member
fabpot commented Mar 4, 2021

I forgot to mention that we tried to remove such string casts in the past from the framework. IIRC, @Tobion was quite vocal about this.

@Tobion
Copy link
Contributor
Tobion commented Mar 5, 2021

👎 #26992 (comment)

@fabpot
Copy link
Member
fabpot commented Mar 5, 2021

Closing as 2 core team members voted against this change.

@fabpot fabpot closed this Mar 5, 2021
@derrabus derrabus mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Routing Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@garak @Nyholm @fabpot @Tobion @derrabus @carsonbot
0