8000 Make sure the Psalm review CI job is working by Nyholm · Pull Request #40308 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make sure the Psalm review CI job is working #40308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

Make sure the Psalm review CI job is working #40308

merged 1 commit into from
Feb 25, 2021

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Feb 25, 2021 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This PR is just a test to make sure psalm works as expected.

EDIT: It also fixes issues..

@carsonbot carsonbot added this to the 4.4 milestone Feb 25, 2021
@Nyholm Nyholm changed the title Test Psalm action Make sure the Psalm review CI job is working Feb 25, 2021
@Nyholm
Copy link
Member Author
Nyholm commented Feb 25, 2021

This are working

Screenshot 2021-02-25 at 17 49 08

@nicolas-grekas
Copy link
Member

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit 07b6efb into symfony:4.4 Feb 25, 2021
@Nyholm Nyholm deleted the psalm-error branch February 25, 2021 16:51
@Nyholm
Copy link
Member Author
Nyholm commented Feb 25, 2021

Thank you for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @nicolas-grekas @carsonbot
0