[WIP] [Messenger] Locate exactly one handler #40254
Conversation
| $this->handlers = $handlers; | ||
| } | ||
|
|
||
| public function getHandlers(Envelope $envelope): iterable |
There was a problem hiding this comment.
Does this need a dock-block?
/**
* {@inheritdoc}
*
* @throws NoHandlerForMessageException When no handler is found class
*/
There was a problem hiding this comment.
Sure, I'll fix all CS if this feature gets interest. Thanks for pointing it out 👍
|
|
||
| public function getHandlers(Envelope $envelope): iterable | ||
| { | ||
| $type = \get_class($envelope->getMessage()); |
There was a problem hiding this comment.
nit pick: This variable is named $class is similar function. e.g. HandlersLocator.php line 69
| { | ||
| $type = \get_class($envelope->getMessage()); | ||
| if (!isset($this->handlers[$type])) { | ||
| throw new NoHandlerForMessageException($type); |
There was a problem hiding this comment.
Shouldn't the error message include the message type, rather that the type/class name
throw new NoHandlerForMessageException($this->handlers[$type]);
Theory being the error message 'Multiple handlers for message "%s"', thus, does this mean $envelope->getMessage()?
There was a problem hiding this comment.
In this specific case, $type holds the message type and $this->handlers[$type] is not set.
Theory being the error message 'Multiple handlers for message "%s"', thus, does this mean $envelope->getMessage()?
I don't understand what you mean.
|
Superseded by #43300 |
Related to #36958
The main idea is to allow definition of a command bus which helps developper detect the following misconfigurations:
Today, only the first case can be detected (this is the default behaviour of the HandleMessageMiddleware), the second one is not (instead, all the command handlers will be called).