-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
install compatible versions of mongodb/mongodb only #40222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Tickets | |
License | MIT |
Doc PR |
.travis.yml
Outdated
@@ -255,7 +255,7 @@ install: | |||
fi | |||
phpenv global $PHP | |||
rm vendor/composer/package-versions-deprecated -Rf | |||
([[ $deps ]] && cd src/Symfony/Component/HttpFoundation; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb ^1.9.0) | |||
([[ $deps ]] && cd src/Symfony/Component/HttpFoundation; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb ~1.8.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title says 1.10.
I think you made a typo somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to install 1.10 first. But that version isn't available through PECL yet. Let's try if not installing mongodb/mongodb
helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb/mongodb
is the higher-level PHP library. That's not the same package that ext-mongodb providing the lower-level driver, and they have separate versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10 does not exists in any of the 2 packages (no idea where this 1.10 comes from in the PR title then). And the library indeed does not have a 1.9 release either. I think the PR should use ^1.8.0
here (rather than switching to a ~
operator) and that the title should be edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the initial draft I tried to install version 1.10 of the PHP extension because of mongodb/mongo-php-library#809. That didn't work out as it's not released yet. So I changed the config to instead limit the installation of mongodb/mongodb
to 1.8 where we do not need to compile the extension ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way, I have updated the PR title accordingly
I'm confused. PECL tells me that 1.9.0 is the most recent release. There is no tag |
So the latest version of the PHP package is 1.8. See https://packagist.org/packages/mongodb/mongodb The PHP extension's latest version is 1.9. Why do you want to update this in the first place? |
Installing |
@xabbuh the PR you linked is not part of mongodb/mongodb 1.9 though. |
ah sorry, there is non 1.9.0 release of I would still use |
I have removed the version constraint completely. I think that should be enough then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you