8000 install compatible versions of mongodb/mongodb only by xabbuh · Pull Request #40222 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

install compatible versions of mongodb/mongodb only #40222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Feb 17, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

.travis.yml Outdated
@@ -255,7 +255,7 @@ install:
fi
phpenv global $PHP
rm vendor/composer/package-versions-deprecated -Rf
([[ $deps ]] && cd src/Symfony/Component/HttpFoundation; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb ^1.9.0)
([[ $deps ]] && cd src/Symfony/Component/HttpFoundation; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb ~1.8.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says 1.10.

I think you made a typo somewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to install 1.10 first. But that version isn't available through PECL yet. Let's try if not installing mongodb/mongodb helps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mongodb/mongodb is the higher-level PHP library. That's not the same package that ext-mongodb providing the lower-level driver, and they have separate versioning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.10 does not exists in any of the 2 packages (no idea where this 1.10 comes from in the PR title then). And the library indeed does not have a 1.9 release either. I think the PR should use ^1.8.0 here (rather than switching to a ~ operator) and that the title should be edited.

Copy link
Member 8000 Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the initial draft I tried to install version 1.10 of the PHP extension because of mongodb/mongo-php-library#809. That didn't work out as it's not released yet. So I changed the config to instead limit the installation of mongodb/mongodb to 1.8 where we do not need to compile the extension ourselves.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, I have updated the PR title accordingly

@derrabus
Copy link
Member

I'm confused. PECL tells me that 1.9.0 is the most recent release.

Bildschirmfoto am 2021-02-17 um 14 17 59

There is no tag 1.10.0 on https://github.com/mongodb/mongo-php-driver either.

@Nyholm
Copy link
Member
Nyholm commented Feb 17, 2021

So the latest version of the PHP package is 1.8. See https://packagist.org/packages/mongodb/mongodb

The PHP extension's latest version is 1.9.

Why do you want to update this in the first place?

@xabbuh xabbuh changed the title use mongodb extension 1.10 do not install mongodb/mongodb 1.9 Feb 17, 2021
@xabbuh
Copy link
Member Author
xabbuh commented Feb 17, 2021

Installing mongodb/mongodb 1.9 used to work before. It's now failing since mongodb/mongo-php-library#809 as in that PR the requirement for ext-mongodb was bumped to 1.10.

@stof
Copy link
Member
stof commented Feb 17, 2021

@xabbuh the PR you linked is not part of mongodb/mongodb 1.9 though.

@stof
Copy link
Member
stof commented Feb 17, 2021

ah sorry, there is non 1.9.0 release of mongodb/mongodb yet. so the previous code was forcing to use an in-progress dev version of the library.

I would still use ^1.8.0 as the requirement, and change the title of the PR. The issue we have is not that we should forbid installing 1.9 of the library, but that we should allow installing a released version (then, composer will take care of selecting the version compatible with the extension, for which we use a released version too)

@xabbuh xabbuh changed the title do not install mongodb/mongodb 1.9 install compatible versions of mongodb/mongodb only Feb 17, 2021
@xabbuh
Copy link
Member Author
xabbuh commented Feb 17, 2021

I have removed the version constraint completely. I think that should be enough then.

Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 1a5aec1 into symfony:4.4 Feb 17, 2021
@xabbuh xabbuh deleted the mongodb branch February 17, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0