8000 [Console] Fix PHP 8.1 null error for preg_match flag by kylekatarnls · Pull Request #40187 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fix PHP 8.1 null error for preg_match flag #40187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

[Console] Fix PHP 8.1 null error for preg_match flag #40187

merged 1 commit into from
Feb 15, 2021

Conversation

kylekatarnls
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Since PHP 8.1, null is no longer accepted as $flags in preg_match, default integer 0 value should be used instead.

@kylekatarnls
[Console] Fix PHP 8.1 null error for preg_match flag
52f02e5 
Since PHP 8.1, null is no longer accepted as $flags, default integer `0` value should be used instead.
@carsonbot carsonbot added this to the 4.4 milestone Feb 14, 2021
rheh
rheh reviewed Feb 14, 2021
View reviewed changes
@xabbuh
Copy link
Member
xabbuh commented Feb 15, 2021

Thank you @kylekatarnls.

@xabbuh xabbuh merged commit e62ef2a into symfony:4.4 Feb 15, 2021
This was referenced Mar 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rheh rheh rheh left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kylekatarnls @xabbuh @nicolas-grekas @rheh @carsonbot
0