8000 [PropertyInfo] fix extracting mixed type-hinted property types by xabbuh · Pull Request #40160 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] fix extracting mixed type-hinted property types #40160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2021
Merged

[PropertyInfo] fix extracting mixed type-hinted property types #40160

merged 1 commit into from
Feb 14, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Feb 12, 2021
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39947
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Feb 12, 2021
@xabbuh xabbuh requested a review from dunglas as a code owner February 12, 2021 10:24
@xabbuh xabbuh mentioned this pull request Feb 12, 2021
Closed
vudaltsov
vudaltsov approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor
@vudaltsov vudaltsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx, this patch fixes the issue.

@fabpot
Copy link
Member
fabpot commented Feb 14, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit 4a32fd0 into symfony:4.4 Feb 14, 2021
@xabbuh xabbuh deleted the issue-39947 branch February 14, 2021 10:55
This was referenced Mar 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@vudaltsov vudaltsov vudaltsov approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @derrabus @vudaltsov @carsonbot
0