8000 [Filesystem] Remove dirs atomically if possible by nicolas-grekas · Pull Request #40144 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Filesystem] Remove dirs atomically if possible #40144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

[Filesystem] Remove dirs atomically if possible #40144

merged 1 commit into from
Feb 11, 2021

Conversation

@nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Feb 10, 2021 •
edited
Loading
Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #27578
License MIT
Doc PR no need to

@carsonbot carsonbot added this to the 4.4 milestone Feb 10, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 10, 2021
Closed
@OskarStark
Copy link
Contributor
OskarStark commented Feb 10, 2021

The PR title looks interesting 😄

@carsonbot carsonbot changed the title Add some information about the username in CONTRIBUTORS [Filesystem] Add some information about the username in CONTRIBUTORS Feb 10, 2021
@derrabus derrabus changed the title [Filesystem] Add some information about the username in CONTRIBUTORS [Filesystem] Remove dirs atomically if possible Feb 10, 2021
@nicolas-grekas nicolas-grekas force-pushed the fs-atomic-remove branch 2 times, most recently from ed64d73 to 6041462 Compare February 10, 2021 17:13
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 5.x February 10, 2021 17:14
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 5.x Feb 10, 2021
@nicolas-grekas
Copy link
Member Author
nicolas-grekas commented Feb 10, 2021 •
edited
Loading

Now targetting 5.x as this looks more like an improvement than a bug fix.

@derrabus
Copy link
Member
derrabus commented Feb 11, 2021

Thank you Nicolas.

@derrabus derrabus merged commit d97ab18 into symfony:5.x Feb 11, 2021
@nicolas-grekas nicolas-grekas deleted the fs-atomic-remove branch February 15, 2021 09:27
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@garethellis36 garethellis36 mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@jderusse jderusse jderusse approved these changes

Assignees

No one assigned

Labels

Bug Filesystem Ready Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

Filesystem remove() function can fail when run concurrently

6 participants

@nicolas-grekas @OskarStark @derrabus @javiereguiluz @jderusse @carsonbot
0