[ErrorHandler] Fix strpos error when trying to call a method without a name #40019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/ErrorHandler/ErrorEnhancer/UndefinedMethodErrorEnhancer.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jan 28, 2021
yceruto
approved these changes
Jan 28, 2021
jderusse
approved these changes
Jan 28, 2021
|
Thank you @Deuchnord. |
888f66c to
66be87b
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the following code:
a fatal error occurs because the method name to execute is empty, but Symfony's error enhancer fails to parse it:
In this PR, I propose a fix with a more clear error to inform the developer about what happened.