8000 Changed private static array-properties to const (5.1) by simonberger · Pull Request #39962 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Changed private static array-properties to const (5.1) #39962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

Changed private static array-properties to const (5.1) #39962

merged 1 commit into from
Jan 25, 2021

Conversation

simonberger
Copy link
Contributor
@simonberger simonberger commented Jan 25, 2021 •
edited
Loading
Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
License MIT

This continues #39959 for 5.1
Just a few newly introduced readonly static array-properties.

/cc @nicolas-grekas

@carsonbot carsonbot added this to the 5.1 milestone Jan 25, 2021
@carsonbot
Copy link

Hey!

This is.. this is amazing. Thank you!

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@simonberger
Changed private static array-properties to const
f891fb2 
static properties newly introduced in 5.1
@simonberger simonberger force-pushed the private-static-array-to-const-51 branch from 6533d94 to f891fb2 Compare January 25, 2021 14:42
@nicolas-grekas
Copy link
Member

Thank you @simonberger.

@nicolas-grekas nicolas-grekas merged commit ac61623 into symfony:5.1 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@simonberger @carsonbot @nicolas-grekas
0