8000 Update PHP CS Fixer config to v2.18 by keradus · Pull Request #39868 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Update PHP CS Fixer config to v2.18 #39868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

Update PHP CS Fixer config to v2.18 #39868

merged 1 commit into from
Jan 19, 2021

Conversation

keradus
Copy link
Member
@keradus keradus commented Jan 18, 2021 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot carsonbot added this to the 4.4 milestone Jan 18, 2021
keradus
keradus commented Jan 18, 2021
View reviewed changes
.php_cs.dist
@@ -11,8 +11,6 @@ return PhpCsFixer\Config::create()
'@Symfony' => true,
'@Symfony:risky' => true,
'protected_to_private' => false,
'native_constant_invocation' => true,
Copy link
Member Author
@keradus keradus Jan 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in continuation of https://github.com/symfony/symfony/pull/39772/files#r554500252 ,

@nicolas-grekas

would you like to update this rule too?
https://cs.symfony.com/doc/rules/function_notation/native_function_invocation.html#strict

@carsonbot

This comment has been minimized.

Sign in to view
@fabpot
Copy link
Member
fabpot commented Jan 19, 2021

FYI, fabbot is using 2.18 since yesterday.

@keradus
Copy link
Member Author
keradus commented Jan 19, 2021

awesome, @fabpot !

@derrabus
Copy link
Member

Thank you @keradus.
-->
@derrabus derrabus merged commit 732bd84 into symfony:4.4 Jan 19, 2021
@keradus keradus deleted the patch-1 branch January 19, 2021 13:04
@wkania wkania mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Deprecation Feature Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@keradus @carsonbot @fabpot @derrabus @nicolas-grekas
0