8000 [HttpKernel] harden test to not depend on the actual time by xabbuh · Pull Request #39706 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] harden test to not depend on the actual time #39706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

[HttpKernel] harden test to not depend on the actual time #39706

merged 1 commit into from
Jan 4, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 4, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

From time to time this test fails (e.g. https://travis-ci.com/github/symfony/symfony/jobs/468014427#L7092). We can fix that by not depending on the system clock which is actually not needed in this test.

@xabbuh xabbuh added this to the 4.4 milestone Jan 4, 2021
@fabpot
Copy link
Member
fabpot commented Jan 4, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit b9bdb8e into symfony:4.4 Jan 4, 2021
@xabbuh xabbuh deleted the file-profiler-storage-tests branch January 4, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
< 476F div class="discussion-sidebar-heading text-bold"> Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @fabpot @carsonbot
0