8000 [Finder] actually compare the order of entries when any sorting is applied by xabbuh · Pull Request #39704 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] actually compare the order of entries when any sorting is applied #39704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

[Finder] actually compare the order of entries when any sorting is applied #39704

merged 1 commit into from
Jan 4, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 4, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Without this change the tests where still passing if the sorting didn't work as expected. There are three more tests that sort by file times. I do not really know how to make them more stable though.

@xabbuh xabbuh added this to the 4.4 milestone Jan 4, 2021
@xabbuh xabbuh force-pushed the finder-compare-sorted-iterators branch from df476b8 to f1ed653 Compare January 4, 2021 11:29
@fabpot
Copy link
Member
fabpot commented Jan 4, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit 135a9b2 into symfony:4.4 Jan 4, 2021
@xabbuh xabbuh deleted the finder-compare-sorted-iterators branch January 4, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Finder Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @fabpot @carsonbot
0