8000 [Form] keep valid submitted choices when additional choices are submitted by xabbuh · Pull Request #39659 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] keep valid submitted choices when additional choices are submitted #39659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

[Form] keep valid submitted choices when additional choices are submitted #39659

merged 1 commit into from
Feb 15, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Dec 29, 2020
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #9738
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Dec 29, 2020
@xabbuh xabbuh requested a review from yceruto as a code owner December 29, 2020 19:25
@xabbuh xabbuh mentioned this pull request Dec 29, 2020
Closed
@xabbuh xabbuh force-pushed the issue-9738 branch 2 times, most recently from 0a427d0 to be00606 Compare December 30, 2020 11:20
@xabbuh
Copy link
Member Author
xabbuh commented Dec 30, 2020

Status: Needs work

@xabbuh xabbuh force-pushed the issue-9738 branch 3 times, most recently from d3b7cd3 to 0c565da Compare December 30, 2020 20:33
@xabbuh
Copy link
Member Author
xabbuh commented Dec 30, 2020

Status: Needs Review

@xabbuh xabbuh force-pushed the issue-9738 branch 2 times, most recently from 4089c9d to f3bf6a5 Compare January 4, 2021 12:50
@xabbuh xabbuh force-pushed the issue-9738 branch 4 times, most recently from f6b4c04 to 29bf41c Compare January 5, 2021 20:21
@xabbuh xabbuh requested a review from nicolas-grekas February 8, 2021 10:45
@xabbuh
8000 Copy link
Member Author
xabbuh commented Feb 8, 2021

@yceruto Can you have a look here please? :)

yceruto
yceruto approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xabbuh xabbuh merged commit 0574c15 into symfony:4.4 Feb 15, 2021
@xabbuh xabbuh deleted the issue-9738 branch February 15, 2021 11:22
This was referenced Mar 4, 2021
Merged
Merged
@Spounespoune Spounespoune mentioned this pull request Mar 16, 2021
Closed
< 969F a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/nanasess/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/nanasess">@nanasess nanasess mentioned this pull request Apr 5, 2021
Merged
11 tasks
@jsfgreen jsfgreen mentioned this pull request Aug 9, 2021
Closed
@xabbuh xabbuh mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @yceruto @carsonbot
0