[Messenger] Templated email messages fails when sending async (thru messenger transport) #39458
Conversation
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | yes |
| New feature? | no |
| Tickets | Fix #39190 |
| License | MIT |
|
What is the intended behaviour when queueing template messages, doing the rendering before enqueuing the message for async sending, OR just before actually sending the message to the mailer transport? In other words, is rendering intended to be done before dispatching to the messenger's bus? I think this clarification is important for a fix. |
6af42cd to
fa6e8e7
Compare
|
One benefit of rendering the template BEFORE queuing, is: the extensions have access to the request context.
When switching to async, you have to provide the needed context (ie. Rendering template is fast. I'm not sure adding such complexity and bugs worth it. |
859598c to
9cf10d5
Compare
9cf10d5 to
3c3c39f
Compare
|
@jderusse +1 on rendering before queuing, this also allows to have a minimalist worker application that only takes care of sending ready-to-send emails. The proposed fix removes the cloning of the message before sending it to the Not sure if the cloning is needed or if removing this can have any other side-effects. Any ideas? Thanks. |
|
Hi! Can anyone provide any updates or guidance on how to proceed? Thanks! |
|
Also looking forward to implement this fix, any idea on when can we expect this to be fixed? |