8000 [ErrorHandler][HttpKernel] Add missing param annotation for $fileLinkFormat by nicolas-grekas · Pull Request #39398 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[ErrorHandler][HttpKernel] Add missing param annotation for $fileLinkFormat #39398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

[ErrorHandler][HttpKernel] Add missing param annotation for $fileLinkFormat #39398

merged 1 commit into from
Dec 9, 2020

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Dec 9, 2020
@nicolas-grekas nicolas-grekas changed the title 23412 Stop treating multiline resources as globs Add missing param annotation abouts $fileLinkFormat Dec 9, 2020
yceruto
yceruto approved these changes Dec 9, 2020 8000
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@derrabus derrabus changed the title Add missing param annotation abouts $fileLinkFormat Add missing param annotation for $fileLinkFormat Dec 9, 2020
@carsonbot carsonbot changed the title Add missing param annotation for $fileLinkFormat [ErrorHandler][HttpKernel] Add missing param annotation for $fileLinkFormat Dec 9, 2020
@derrabus
Copy link
Member
derrabus commented Dec 9, 2020

Good catch, thanks Nicolas.

@derrabus derrabus merged commit 0676399 into symfony:4.4 Dec 9, 2020
@nicolas-grekas nicolas-grekas deleted the param-fmt branch December 16, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
ErrorHandler HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @derrabus @yceruto @carsonbot
0