8000 Remove not used mailer_transport.xml service config by jschaedl · Pull Request #39315 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove not used mailer_transport.xml service config #39315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove not used mailer_transport.xml service config #39315

merged 1 commit into from
Dec 4, 2020

Conversation

jschaedl
Copy link
Contributor
@jschaedl jschaedl commented Dec 4, 2020 •
edited
Loading
Q A
Branch? 5.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR -

All xml service configs should actually have been removed related to #37186
I double checked, but couldn't find any usages of mailer_transports.xml, so I removed it.

@jschaedl jschaedl changed the base branch from 5.x to 5.2 December 4, 2020 20:46
@chalasr
Copy link
Member
chalasr commented Dec 4, 2020

Good catch, thanks @jschaedl.

@chalasr chalasr merged commit 34d9455 into symfony:5.2 Dec 4, 2020
@xabbuh xabbuh added this to the 5.2 milestone Dec 5, 2020
@jschaedl jschaedl deleted the remove-xml-config branch June 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jschaedl @chalasr @xabbuh @carsonbot
0