10000 Fix jsonRequest in `AbstractBrowser` for GET methods by alexander-schranz · Pull Request #39281 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix jsonRequest in AbstractBrowser for GET methods #39281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix jsonRequest in AbstractBrowser for GET methods #39281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589d06f
Fix jsonRequest in AbstractBrowser for GET Methods
alexander-schranz Dec 2, 2020
0411c79
Remove JSON_THROW_ERROR conditional to behave the same in all PHP Ver…
alexander-schranz Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove JSON_THROW_ERROR conditional to behave the same in all PHP Ver… 
…sions
  • Loading branch information
@alexander-schranz
alexander-schranz authored Dec 10, 2020
commit 0411c79f39539690072f54d450e4ddd514348efd
2 changes: 1 addition & 1 deletion src/Symfony/Component/BrowserKit/AbstractBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function jsonRequest(string $method, string $uri, array $parameters = [],
case 'PUT':
case 'DELETE':
case 'PATCH':
$content = json_encode($parameters, \defined('JSON_THROW_ON_ERROR') ? \JSON_THROW_ON_ERROR : 0);
$content = json_encode($parameters);
$query = [];
break;
default:
Expand Down
0