8000 [FrameworkBundle] [minor] adjust KernelBrowser::getProfile() typehint by kbond · Pull Request #39198 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] [minor] adjust KernelBrowser::getProfile() typehint #39198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

[FrameworkBundle] [minor] adjust KernelBrowser::getProfile() typehint #39198

merged 1 commit into from
Nov 28, 2020

Conversation

kbond
Copy link
Member
@kbond kbond commented Nov 27, 2020 •
edited by derrabus
Loading
Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Profiler::loadProfileFromResponse() can return null. Obviously having a return of null|false is unfortunate. Not sure what we can do about that...

@carsonbot carsonbot changed the title [minor] adjust KernelBrowser::getProfile() typehint [FrameworkBundle] [minor] adjust KernelBrowser::getProfile() typehint Nov 27, 2020
@derrabus derrabus added this to the 5.1 milestone Nov 27, 2020
@derrabus
Copy link
Member

This needs to be fixed on the 5.1 branch.

@derrabus
Copy link
Member

… and on 4.4 for the Symfony\Bundle\FrameworkBundle\Client class.

@kbond kbond force-pushed the get-profile-typehint branch from 76e39a3 to ce046fd Compare November 27, 2020 14:09
@kbond kbond changed the base branch from 5.x to 5.1 November 27, 2020 14:09
@kbond kbond mentioned this pull request Nov 27, 2020
Merged
derrabus added a commit that referenced this pull request Nov 27, 2020
@derrabus
minor #39199 [FrameworkBundle] [minor] adjust Client::getProfile() ty…
986f99d 
…pehint (kbond)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] [minor] adjust Client::getProfile() typehint

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

#39198's fix for 4.4.

Commits
-------

5f2bb90 adjust Client::getProfile() typehint
@derrabus
Copy link
Member

Good catch, thanks @kbond.

@derrabus derrabus merged commit 441ceec into symfony:5.1 Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @derrabus @carsonbot
0