[FrameworkBundle] Make session save path configurable #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ | |||
| <parameter key="session.class">Symfony\Component\HttpFoundation\Session\Session</parameter> | |||
| <parameter key="session.flashbag.class">Symfony\Component\HttpFoundation\Session\Flash\AutoExpireFlashBag</parameter> | |||
| <parameter key="session.attribute_bag.class">Symfony\Component\HttpFoundation\Session\Attribute\AttributeBag</parameter> | |||
| <parameter key="session.save_path" /> | |||
There was a problem hiding this comment.
this is useless as the DI extension always set it
|
It might be good to default this value to |
|
@stloyd need my eyes checked :-P |
fabpot
added a commit
that referenced
this pull request
Apr 13, 2012
Commits ------- c0e7ee9 [FrameworkBundle] Make session save path configurable Discussion ---------- [FrameworkBundle] Make session save path configurable Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: [](http://travis-ci.org/asm89/symfony) Makes it possible to configure the session save path. It still defaults to saving sessions in the kernel cache dir. This might not be appropriate if you want to keep your user sessions after deploying your application. As promised to @fabpot I will also do a PR on the docs explaining why this might be useful. --------------------------------------------------------------------------- by drak at 2012-04-13T10:16:17Z It might be good to default this value to `%kernel.cache_dir%/sessions`. --------------------------------------------------------------------------- by stloyd at 2012-04-13T10:30:58Z @Drak https://github.com/symfony/symfony/pull/3912/files#L0R184 --------------------------------------------------------------------------- by drak at 2012-04-13T10:31:57Z @stloyd need my eyes checked :-P
|
I don't see why sessions would be stored in the cache folder. |
|
This is just a default as we know that this directory is writable. But as this is configurable, feel free to move them anywhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass:
Makes it possible to configure the session save path. It still defaults to saving sessions in the kernel cache dir. This might not be appropriate if you want to keep your user sessions after deploying your application.
As promised to @fabpot I will also do a PR on the docs explaining why this might be useful.