8000 [PhpUnitBridge] Add log file option for deprecations by michaelKaefer · Pull Request #39098 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Add log file option for deprecations #39098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

[PhpUnitBridge] Add log file option for deprecations #39098

merged 1 commit into from
Jan 5, 2021

Conversation

@michaelKaefer
Copy link
Contributor
@michaelKaefer michaelKaefer commented Nov 16, 2020
Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #37679
License MIT
Doc PR symfony/symfony-docs#14558

@michaelKaefer michaelKaefer mentioned this pull request Nov 16, 2020
Merged
@wouterj wouterj added this to the 5.x milestone Nov 16, 2020
@carsonbot carsonbot changed the title 37679 Add log file option for deprecations [PhpUnitBridge] 37679 Add log file option for deprecations Nov 16, 2020
@michaelKaefer michaelKaefer reopened this Nov 16, 2020
noniagriconomie
noniagriconomie reviewed Nov 17, 2020
View reviewed changes
@michaelKaefer
Copy link
Contributor Author
michaelKaefer commented Nov 18, 2020

@noniagriconomie Thank you for the review! I have a question concerning the scalar type hints and the return types: are you sure I should add them? The reason why I didn't:

  • They are not allowed in the PHP version (5.5.9) specified in composer.json

More reasons (maybe not valid reasons):

  • The only other files that use PHP 7 typing are in the Legacy/ directory (if I looked correctly)
  • Code style: they would be the only ones in the whole file

@noniagriconomie
Copy link
Contributor
noniagriconomie commented Nov 20, 2020

@michaelKaefer you are right yep

I was thinking v5 was 7+ and I checked the main repo composer.json, not the one of the bridge, sorry for this wrong hint :/

@stof
Copy link
Member
stof commented Nov 20, 2020

I was thinking v5 was 7+

The PHPUnit bridge is special in its PHP support. To make our maintenance easier, the latest version of the phpunit bridge is kept compatible with PHP versions supported by all maintained branches (and so the min version corresponds to the one of the LTS)

@noniagriconomie
Copy link
Contributor
noniagriconomie commented Nov 20, 2020

@stof very clear :) thx for this explanation

@nicolas-grekas nicolas-grekas changed the title [PhpUnitBridge] 37679 Add log file option for deprecations [PhpUnitBridge] Add log file option for deprecations Dec 8, 2020
nicolas-grekas
nicolas-grekas reviewed Dec 8, 2020
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Dec 8, 2020
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Dec 10, 2020
View reviewed changes
@michaelKaefer michaelKaefer force-pushed the 37679-log-deprecations branch 2 times, most recently from 3b50ce3 to 74dfbb6 Compare December 10, 2020 18:55
nicolas-grekas
nicolas-grekas reviewed Dec 11, 2020
View reviewed changes
@michaelKaefer michaelKaefer force-pushed the 37679-log-deprecations branch 4 times, most recently from cb6537f to ad78189 Compare December 23, 2020 19:13
@nicolas-grekas nicolas-grekas force-pushed the 37679-log-deprecations branch from ad78189 to 3ed22be Compare January 5, 2021 19:06
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Jan 5, 2021

Thank you @michaelKaefer.

@nicolas-grekas nicolas-grekas merged commit 80bde1e into symfony:5.x Jan 5, 2021
@michaelKaefer michaelKaefer deleted the 37679-log-deprecations branch January 5, 2021 21:53
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Jan 7, 2021
@OskarStark
feature #14558 [PHPUnitBridge] Add deprecation log file option (micha…
3bd092c 
…elKaefer)

This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[PHPUnitBridge] Add deprecation log file option

For PR symfony/symfony#39098

Commits
-------

66d5f49 [PHPUnitBridge] Add deprecation log file option
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@noniagriconomie noniagriconomie noniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature PhpUnitBridge Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

bin/phpunit with possibility to save deprecations

6 participants

@michaelKaefer @noniagriconomie @stof @nicolas-grekas @wouterj @carsonbot
0