[ProxyManagerBridge] replace ProxyManager\Version by feature detection #39017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Nov 6, 2020
fabpot
approved these changes
Nov 6, 2020
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 22, 2021
…poser/package-versions-deprecated (stof) This PR was merged into the 4.4 branch. Discussion ---------- [ProxyManagerBridge] Remove the unused dependency on composer/package-versions-deprecated | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes/no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | n/a The ProxyManagerBridge depends on friendsofphp/proxy-manager-lts which has an optional dependency on the PackageVersions class to implement the `ProxyManager\Version::getVersion` method on composer 1 (with a fallback to a less precise version number). However, the bridge has stopped using that API in favor of feature detection (in #39017), so the dependency is unused. This contributes to #44726 Commits ------- 6ca8e30 Remove the unused dependency on composer/package-versions-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get rid of this
Versionclass, which is the source of so many issues with deps.This won't remove the class from ocramius/proxy-manager, but that's a separate story that this change could enable in the end :)