Allow user to override default options when extending the Choice Cons…

…traint Co-authored-by: Maxime Steinhausser <maxime.steinhausser@gmail.com>
symfony · ogizanagi · Nov 7, 2020 · Nov 5, 2020 · Nov 7, 2020 · d55375005403062e6fe3c9acc0b2d9aaacb26cf3
commit d55375005403062e6fe3c9acc0b2d9aaacb26cf3
diff --git a/src/Symfony/Component/Validator/Constraints/Choice.php b/src/Symfony/Component/Validator/Constraints/Choice.php
@@ -69,7 +69,7 @@ public function __construct(
         if (\is_array($choices) && \is_string(key($choices))) {
             $options = array_merge($choices, $options);
         } elseif (null !== $choices) {
-            $options['choices'] = $choices;
+            $options['value'] = $choices;
         }
 
         parent::__construct($options, $groups, $payload);

diff --git a/src/Symfony/Component/Validator/Tests/Constraints/ChoiceTest.php b/src/Symfony/Component/Validator/Tests/Constraints/ChoiceTest.php
@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Validator\Tests\Constraints;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Validator\Tests\Fixtures\ConstraintChoiceWithPreset;
+
+class ChoiceTest extends TestCase
+{
+    public function testSetDefaultPropertyChoice()
+    {
+        $constraint = new ConstraintChoiceWithPreset('A');
+
+        self::assertEquals(['A', 'B', 'C'], $constraint->choices);
+    }
+}
diff --git a/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintChoiceWithPreset.php b/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintChoiceWithPreset.php
@@ -0,0 +1,34 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Validator\Tests\Fixtures;
+
+use Symfony\Component\Validator\Constraints\Choice;
+
+class ConstraintChoiceWithPreset extends Choice
+{
+    public $type;
+
+    public function __construct(string $type) {
+        parent::__construct($type);
+
+        if ($this->type === 'A') {
+            $this->choices = ['A', 'B', 'C'];
+        } else {
+            $this->choices = ['D', 'E', 'F'];
+        }
+    }
+
+    public function getDefaultOption(): ?string
+    {
+        return 'type';
+    }
+}