8000 [EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber · Pull Request #3900 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Apr 12, 2012
Merged

[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber #3900

merged 1 commit into from Apr 12, 2012

Conversation

ghost
Copy link
@ghost ghost commented Apr 12, 2012

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This fixes a case that was not covered by the existing tests.

fabpot added a commit that referenced this pull request Apr 12, 2012
Commits
-------

57dd914 [EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber with mixed priorities

Discussion
----------

[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This fixes a case that was not covered by the existing tests.
@fabpot fabpot merged commit 57dd914 into symfony:2.0 Apr 12, 2012
return array(
'pre.foo' => array('preFoo', 10),
'post.foo' => array('postFoo'),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS: this should probably be unindented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for readability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant:

return array(
    'pre.foo' => array('preFoo', 10),
    'post.foo' => array('postFoo'),
);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0