[HttpClient] Check status code before decoding content in TraceableResponse #38977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa42935 to
f84c83b
Compare
f84c83b to
59dc108
Compare
nicolas-grekas
approved these changes
Nov 3, 2020
jderusse
reviewed
Nov 3, 2020
src/Symfony/Component/HttpClient/Response/TraceableResponse.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Nov 3, 2020
src/Symfony/Component/HttpClient/Response/TraceableResponse.php
Outdated
Show resolved
Hide resolved
b71b74d to
57f289a
Compare
57f289a to
b69a995
Compare
src/Symfony/Component/HttpClient/Response/TraceableResponse.php
Outdated
Show resolved
Hide resolved
3009516 to
c4f2d20
Compare
7264c27 to
640fa70
Compare
640fa70 to
e5595da
Compare
|
Good catch, thanks @chalasr. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
toArray()on the response of a traceable client, the status code is currently checked after json decoding, which leads toJsonExceptionbeing thrown instead ofClientException.It should be the opposite, as for non-traceable responses.