8000 [Messenger] Fixed tests with doctrine 3 by Nyholm · Pull Request #38947 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Fixed tests with doctrine 3 #38947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2020
Merged

[Messenger] Fixed tests with doctrine 3 #38947

merged 1 commit into from
Nov 1, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Nov 1, 2020
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Tests on 4.4 is failing with:

  1. Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineReceiverTest::testOccursRetryableExceptionFromConnection
    TypeError: Argument 1 passed to Doctrine\DBAL\Exception\DriverException::__construct() must implement interface Doctrine\DBAL\Driver\Exception, string given, called in /home/travis/build/symfony/symfony/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineReceiverTest.php on line 80

This will make sure the tests supports doctrine/dbal 3.

@Nyholm Nyholm requested a review from sroze as a code owner November 1, 2020 18:06
@carsonbot carsonbot added this to the 4.4 milestone Nov 1, 2020
@Nyholm Nyholm force-pushed the messenger-doctrine-3 branch from 1fbaad9 to f3b2b3c Compare November 1, 2020 18:57
@derrabus derrabus force-pushed the messenger-doctrine-3 branch from f3b2b3c to c377f73 Compare November 1, 2020 19:02
@derrabus
Copy link
Membe 8000 r
derrabus commented Nov 1, 2020

Thank you Tobias.

@derrabus derrabus merged commit 91fb5fa into symfony:4.4 Nov 1, 2020
@Nyholm
Copy link
Member Author
Nyholm commented Nov 1, 2020

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @derrabus @carsonbot
0