8000 [Finder] Force set access time in test by Nyholm · Pull Request #38945 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] Force set access time in test #38945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

[Finder] Force set access time in test #38945

merged 1 commit into from
Nov 2, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Nov 1, 2020
Q A
Branch? 4.4
Bug fix? no, it only updates the tests
New feature? no
Deprecations? no
Tickets Fix #38942
License MIT
Doc PR

OSX don't really update atime (access time). They claim it is because performance reasons. So this PR will update the test to make PHP force access time on a file.

The different runs of testAccept depends on each other because each test modifies the filesystem a bit. That is why I added the extra sleep(1).

@carsonbot carsonbot added this to the 4.4 milestone Nov 1, 2020
derrabus
derrabus approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the changes fix the problem for me locally. And if I revert either of the changes, the tests are red again.

@Nyholm Nyholm force-pushed the finder-test-force branch from 707bbb9 to c5ec51a Compare November 1, 2020 19:04
@fabpot
Copy link
Member
fabpot commented Nov 2, 2020

Thank you @Nyholm.

@fabpot fabpot merged commit 5c3781a into symfony:4.4 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Finder Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @fabpot @derrabus @carsonbot
0