Validate XLIFF files in tests using the XSD #38939
Merged
10BC0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Nov 1, 2020
Member
There was a problem hiding this comment.
Thank you.
Yeah, this would be helpful.
jderusse
approved these changes
Nov 1, 2020
derrabus
reviewed
Nov 1, 2020
Member
There was a problem hiding this comment.
Very good. This change also removes a dependency on a internal PHPUnit class that has caused us trouble recently. 👍🏻
src/Symfony/Component/Form/Tests/Resources/TranslationFilesTest.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Nov 1, 2020
src/Symfony/Component/Validator/Tests/Resources/TranslationFilesTest.php
Outdated
Show resolved
Hide resolved
derrabus
approved these changes
Nov 1, 2020
fabpot
approved these changes
Nov 1, 2020
Member
|
Thank you @wouterj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tests only validated that the Xliff files were valid XML. This improves it to also validate the Xliff files against the correct XSD. This will avoid issues like #38935 in the future.
cc @Nyholm