10000 Fixing some Mongolian by Nyholm · Pull Request #38917 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fixing some Mongolian #38917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Fixing some Mongolian #38917

merged 1 commit into from
Nov 2, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Oct 31, 2020
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38916
License MIT
Doc PR

Hey @luffy1727, could you help me with the last two strings here?

@carsonbot carsonbot added this to the 4.4 milestone Oct 31, 2020
</trans-unit>
<trans-unit id="39">
<source>This value is not a valid locale.</source>
<target>This value is not a valid locale.</target>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be translated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could say "Энэ утга үнэн зөв байршил биш байна"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure it refers to a locale, like "sv", "en", "fr", "mn". Google translates this to "location".

Is there a better (maybe more technical) word we can use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i don`t think there is. The closest thing would be "Энэ утга үнэн зөв орчин биш байна"

<source>This value is not a valid language.</source>
<target>Энэ утга үнэн зөв хэл биш байна .</target>
<target>This value is not a valid language.</target>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be translated

@nicolas-grekas
Copy link
Member

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit cd53800 into symfony:4.4 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0