8000 [HttpKernel] HttpKernelBrowser: don't set a default Accept header by dunglas · Pull Request #38819 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] HttpKernelBrowser: don't set a default Accept header #38819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

[HttpKernel] HttpKernelBrowser: don't set a default Accept header #38819

merged 1 commit into from
Oct 27, 2020

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Oct 26, 2020 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33393
License MIT
Doc PR n/a

Currently, the Accept HTTP header is set automatically, because there is a default value for this value in HttpFoundation's Request::create() method.
This PR remove the default value if it hasn't been set automatically.

This will fix API Platform's ApiTestCase and Behatch/contexts (the previous workarounds aren't applicable anymore because we added type checks in Symfony).

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 26, 2020
nicolas-grekas
nicolas-grekas approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.4, to keep 3.4 in peace?

@dunglas
Copy link
Member Author
dunglas commented Oct 26, 2020

As suggested by @chalasr, this could even be considered a "new feature". WDYT?

@fabpot
Copy link
Member
fabpot commented Oct 27, 2020

If we're not comfortable with merging it in 3.4, let's move it to 5.x (last call for 5.2).

@dunglas dunglas changed the base branch from 3.4 to 5.x October 27, 2020 07:56
@dunglas
Copy link
Member Author
dunglas commented Oct 27, 2020

done

@nicolas-grekas nicolas-grekas modified the milestones: 3.4, 5.2 Oct 27, 2020
@nicolas-grekas
Copy link
Member

Thank you @dunglas.

@nicolas-grekas nicolas-grekas merged commit 27341b5 into symfony:5.x Oct 27, 2020
@dunglas dunglas deleted the fix/issue-33393 branch October 27, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Ability to unset a default header added by HttpKernelBrowser / Client
5 participants
@dunglas @fabpot @nicolas-grekas @chalasr @carsonbot
0