8000 [HttpClient] Add a Stopwatch on TraceableHttpClient by jderusse · Pull Request #38688 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] Add a Stopwatch on TraceableHttpClient #38688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

[HttpClient] Add a Stopwatch on TraceableHttpClient #38688

merged 1 commit into from
Oct 23, 2020

Conversation

jderusse
Copy link
Member
@jderusse jderusse commented Oct 23, 2020 •
edited
Loading
Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

I used this code to generate the screenshot below.

$response = $client->request('GET', 'https://httpstat.us/200');
$response->getContent();

$responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=300');
$responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=100');
foreach ($client->stream($responses) as $chunk) {
}

Screenshot from 2020-10-23 02-04-43

Nyholm
Nyholm approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent idea. Thank you

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 23, 2020
nicolas-grekas
nicolas-grekas reviewed Oct 23, 2020
View reviewed changes
src/Symfony/Component/HttpClient/Response/TraceableResponse.php Outdated
@@ -132,6 +170,9 @@ public static function stream(HttpClientInterface $client, iterable $responses,
}

foreach ($client->stream($wrappedResponses, $timeout) as $r => $chunk) {
if ($traceableMap[$r]->event && $traceableMap[$r]->event->isStarted() && $chunk->isLast()) {
Copy link
Member
@nicolas-grekas nicolas-grekas Oct 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling isLast() without checking for getError will throw when an error happens (same for timeouts)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
I added lap on timeout and chunk (same for getStatus and getHeader) To show a "tick" when content is partially received.

Screenshot from 2020-10-23 10-52-45

        $response1 = $client->request('GET', 'https://httpstat.us/200');
        $response1->getContent(false);
        $response2 = $client->request('GET', 'https://httpstat.us/404');
        $response2->getContent(false);

        $responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=3000');
        $responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=500');
        try {
            foreach ($client->stream($responses, 1) as $chunk) {}
        } catch (\Exception $e)
        {}
        sleep(1);
        foreach ($responses as $response) {
            $response->getContent();
        }

@jderusse jderusse force-pushed the hc-stopwatch branch 3 times, most recently from bcab52a to 5759497 Compare October 23, 2020 09:00
stof
stof reviewed Oct 23, 2020
View reviewed changes
@jderusse jderusse force-pushed the hc-stopwatch branch 2 times, most recently from a7f9109 to ff928bc Compare October 23, 2020 10:03
@nicolas-grekas nicolas-grekas modified the milestones: 5.2, 5.x Oct 23, 2020
@fabpot
Copy link
Member
fabpot commented Oct 23, 2020

Thank you @jderusse.

@fabpot fabpot mentioned this pull request Oct 23, 2020
Closed
@fabpot fabpot merged commit 1280e53 into symfony:5.x Oct 23, 2020
@jderusse jderusse deleted the hc-stopwatch branch October 25, 2020 19:49
@jderusse jderusse mentioned this pull request Oct 26, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@jderusse @fabpot @nicolas-grekas @stof @Nyholm @carsonbot
0