10000 [PHPUnitBridge] Support PHPUnit 8 and PHPUnit 9 in constraint compatibility trait by alcaeus · Pull Request #38681 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PHPUnitBridge] Support PHPUnit 8 and PHPUnit 9 in constraint compatibility trait #38681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

[PHPUnitBridge] Support PHPUnit 8 and PHPUnit 9 in constraint compatibility trait #38681

merged 1 commit into from
Oct 23, 2020

Conversation

alcaeus
Copy link
Contributor
@alcaeus alcaeus commented Oct 22, 2020
Q A
Branch? 5.x
Bug fix? not really
New feature? yes
Deprecations? no
License MIT

This expands the compatibility layer for PHPUnit constraints by supporting PHPUnit 8 and PHPUnit 9. Support for the latter requires also adding the evaluate method to the trait, as this method gets a signature change in PHPUnit 9.

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 22, 2020
@alcaeus alcaeus changed the base branch from 5.x to 4.4 October 22, 2020 12:30
@alcaeus alcaeus force-pushed the phpunit-bridge-phpunit-9-compat-layer branch from be2ddd3 to f79ad80 Compare October 22, 2020 12:30
@nicolas-grekas nicolas-grekas modified the milestones: 5.2, 4.4 Oct 22, 2020
@fabpot
Copy link
Member
fabpot commented Oct 23, 2020

Thank you @alcaeus.

@fabpot fabpot merged commit 49182e1 into symfony:4.4 Oct 23, 2020
@alcaeus alcaeus deleted the phpunit-bridge-phpunit-9-compat-layer branch October 23, 2020 05:34
This was referenced Oct 28, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Feature PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@alcaeus @fabpot @nicolas-grekas @jderusse @derrabus @carsonbot
0