[FrameworkBundle] Deprecate lock service #38576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 15, 2020
|
Thank you @jderusse. |
derrabus
added a commit
that referenced
this pull request
Oct 15, 2020
…ices (jderusse) This PR was merged into the 5.x branch. Discussion ---------- [FrameworkBundle] Missing Changelog for deprecating services | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | / | License | MIT | Doc PR | / I forgot to add CHANGELOG/UPGRADE when deprecating alias `lock` in #38576. (thank you @nicolas-grekas for reminding this) This PR also adds a missing alias registered for argument. Commits ------- f9ddc5c Missing Changelog for deprecating services
fabpot
added a commit
that referenced
this pull request
Oct 16, 2020
…cate lock.store services (jderusse) This PR was merged into the 5.x branch. Discussion ---------- [Lock][Semaphore] Add Factory::createFromKey and deprecate lock.store services I| Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | / | License | MIT | Doc PR | todo The `lock` service and aliases have been deprecated in #38576. This PR also deprecate the `lock.store` service and aliases. People should always inject the factory into their services, except for one scenario: When they want building the `Lock` manually because they want to keep the key. This scenario require declaring `lock.store` service and `PersisingStoreInterface` aliases. This could be avoided if people had a method to create a lock from a given key. This PR adds a `LockFactory::createFromKey()` method and deprecate all `lock.store` services I also updated the Semaphore component for consistency, and helping people to only inject the SemahoreFactory. nb: use cases for serializing the keys: - Netflix allows only 5 users of the same family at the same time. - An holiday apartment rental avoid users putting the same apartment in the basket - ... Commits ------- 91fa3e3 Deprecate lock.store aliases
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecate the
lock,LockInterfaceservice ass discussed in #38458