8000 Add wouterj as codeowner for Security related packages by wouterj · Pull Request #38574 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add wouterj as codeowner for Security related packages #38574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add wouterj as codeowner for Security related packages #38574

merged 1 commit into from
Oct 14, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Oct 14, 2020 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This is what I've manually been doing since the 5.1 release. Now that I'm part of the Symfony mergers team, I would be happy to let GitHub ping important PRs for me automatically :)

as 3.4 is closing the end of its maintenance lifetime, I think it'll save some merge conflicts to only add this in 4.4+

derrabus
derrabus approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Symfony 3.4 bugfix support is going to end soon. On the other hand, a fix for a bug that is present in 3.4 already will be submitted against the 3.4 branch and merged up to 4.4 afterwards. Because of that, targeting 3.4 seems reasonable to me.

@chalasr
Copy link
Member
chalasr commented Oct 14, 2020

Thank you @wouterj.

@chalasr chalasr merged commit 4a221f8 into symfony:4.4 Oct 14, 2020
@wouterj wouterj deleted the codeowner branch October 15, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @chalasr @OskarStark @derrabus @carsonbot
0