8000 [CI] Fixed build on AppVeyor by Nyholm · Pull Request #38556 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[CI] Fixed build on AppVeyor #38556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

[CI] Fixed build on AppVeyor #38556

merged 1 commit into from
Oct 14, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Oct 13, 2020
Q A
Branch? 5.x
Bug fix?
New feature?
Deprecations?
Tickets
License MIT
Doc PR

CI fails on AppVeyor with:

There was 1 error:

  1. Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\ConfigurationTest::testBaselineFileWriteError
    unlink(C:\Users\appveyor\AppData\Local\Temp\1\sf-38AF.tmp): Permission denied
    C:\projects\symfony\src\Symfony\Bridge\PhpUnit\Tests\DeprecationErrorHandler\ConfigurationTest.php:404
    ERRORS!

We dont need to fail the tests if we cannot remove a file on tearDown()

@Nyholm
Copy link
Member Author
Nyholm commented Oct 13, 2020

Should I silence errors on unlink in all tearDown()?

Currently there is about 50/50 if we silence errors or not.

@fabpot
Copy link
Member
fabpot commented Oct 14, 2020

@Nyholm CAn you indeed do that everywhere in tests?

@Nyholm Nyholm requested review from sroze and xabbuh as code owners October 14, 2020 06:36
@Nyholm
Copy link
Member Author
Nyholm commented Oct 14, 2020

Sure. There you go

fabpot
fabpot approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you submit the same on 3.4?

@Nyholm
Copy link
Member Author
Nyholm commented Oct 14, 2020

Sure!

@Nyholm Nyholm mentioned this pull request Oct 14, 2020
Merged
@Nyholm
Copy link
Member Author
Nyholm commented Oct 14, 2020

Here you go: #38560

fabpot added a commit that referenced this pull request Oct 14, 2020
@fabpot
minor #38560 [CI] Silence errors when remove file/dir on test tearDow…
9b2dcac 
…n() (Nyholm)

This PR was merged into the 3.4 branch.

Discussion
----------

[CI] Silence errors when remove file/dir on test tearDown()

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  |
| Deprecations? |
| Tickets       |
| License       | MIT
| Doc PR        |

Requested in #38556

Commits
-------

efef41f [CI] Silence errors when remove file/dir on test tearDown()
@fabpot fabpot changed the base branch from 5.x to 5.1 October 14, 2020 09:34
@fabpot
Copy link
Member
fabpot commented Oct 14, 2020

Thank you @Nyholm.

@fabpot fabpot merged commit 268e9e3 into symfony:5.1 Oct 14, 2020
@xabbuh xabbuh added this to the 5.1 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @fabpot @nicolas-grekas @xabbuh @carsonbot
0