[HttpKernel] add kernel.runtime_environment = %env(default:kernel.environment:APP_RUNTIME_ENV)% parameter
#38543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not |
5cd483f to
3131e20
Compare
Because it's shorter and equally descriptive to me. |
jderusse
approved these changes
Oct 15, 2020
…environment:APP_RUNTIME_ENV)%` parameter
kernel.runtime_env = %env(default:kernel.environment:APP_RUNTIME_ENV)% parameterkernel.runtime_environment = %env(default:kernel.environment:APP_RUNTIME_ENV)% parameter
3131e20 to
6eb9d62
Compare
fabpot
approved these changes
Oct 21, 2020
|
Thank you @nicolas-grekas. |
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 27, 2021
This PR was merged into the 5.2 branch. Discussion ---------- [secrets] Use APP_RUNTIME_ENV to define secrets Use new env variable introduced in symfony/symfony#38543 to define secrets. /cc `@nicolas`-grekas Commits ------- 9994e7b Use APP_RUNTIME_ENV to define secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #37584
This PR adds a new
kernel.runtime_environmentparameter, which creates a convention to use theAPP_RUNTIME_ENVenv var to define the name of the runtime environment where the app is deployed.When this env var is not set, the parameter defaults to
kernel.environment.This is especially useful for defining the location of the vault for secrets: an app can be deployed in "prod" mode, but still not be deployed on the real prod deployment target. When this happens, one might not use real prod secrets but instead, use a vault with creds for staging.
This parameter enables this use case.