8000 [Validator] Upgraded constraints to enable named arguments and attributes by derrabus · Pull Request #38499 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Upgraded constraints to enable named arguments and attributes #38499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2020
Merged

[Validator] Upgraded constraints to enable named arguments and attributes #38499

merged 1 commit into from
Oct 11, 2020

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Oct 9, 2020
Q A
Branch? 5.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets #38096
License MIT
Doc PR TODO with symfony/symfony-docs#14305

This PR enables all remaining atomic (!= composite) constraints to be used as attributes.

The only exception is UniqueEntity from Doctrine bridge because we don't have a Doctrine ORM release yet that supports PHP 8. So I could migrate that one as well, but I cannot really test it.

@derrabus derrabus mentioned this pull request Oct 9, 2020
Closed
@derrabus derrabus force-pushed the improvement/attribute-constraints branch from ea652da to 8e9ba6e Compare October 9, 2020 14:52
@fabpot
Copy link
Member
fabpot commented Oct 10, 2020

@derrabus Can you have a look at the failing test?

@derrabus
Copy link
Member Author

@fabpot The failing Validator tests on the php 7.4 run also fail on 5.x and seem to be related to the new baseline feature added with #37733.

@fabpot fabpot force-pushed the improvement/attribute-constraints branch from 8e9ba6e to fb99eb2 Compare October 11, 2020 06:04
@fabpot
Copy link
Member
fabpot commented Oct 11, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 87920d2 into symfony:5.x Oct 11, 2020
@derrabus derrabus deleted the improvement/attribute-constraints branch October 11, 2020 10:25
@derrabus derrabus mentioned this pull request Oct 12, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 14, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 21, 2020
@xabbuh xabbuh mentioned this pull request Jul 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Validator
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @fabpot @nicolas-grekas @carsonbot
0