10000 [HttpClient] change piority of RetryableHttpClient by jderusse · Pull Request #38413 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] change piority of RetryableHttpClient #38413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

[HttpClient] change piority of RetryableHttpClient #38413

merged 1 commit into from
Oct 5, 2020

Conversation

jderusse
Copy link
Member
@jderusse jderusse commented Oct 4, 2020
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets /
License MIT
Doc PR /

This make the RetryableHttpClient decorated the TraceableHttpClient.
User will be able to check content of each sub-request

nicolas-grekas
nicolas-grekas reviewed Oct 5, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-10 to allow anyone to hook in between?

@jderusse
Copy link
Member Author
jderusse commented Oct 5, 2020 •
edited
Loading

changed to -10.

FYI, here is the render (this change leak the ['buffer'=>false] injected by the StreamResponse

before after
Screenshot from 2020-10-05 10-02-40 Screenshot from 2020-10-05 10-01-54

@nicolas-grekas nicolas-grekas added this to the next milestone Oct 5, 2020
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 5a3e1db into symfony:master Oct 5, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@jderusse jderusse deleted the retry-traceable branch October 15, 2020 10:01
@jderusse jderusse mentioned this pull request Oct 19, 2020
Merged
fabpot added a commit that referenced this pull request Oct 21, 2020
@fabpot
bug #38633 [HttpClient] Fix decorating progress info in AsyncResponse…
508ec9c 
… (jderusse)

This PR was squashed before being merged into the 5.x branch.

Discussion
----------

[HttpClient] Fix decorating progress info in AsyncResponse

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38631
| License       | MIT
| Doc PR        | /

This PR reverts #38413, and send AsyncContext to onProgress callback.

Commits
-------

e325f51 [HttpClient] Fix decorating progress info in AsyncResponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @nicolas-grekas @fabpot @carsonbot
0